I think the Framework laptop is absolutely good for the industry. Many of your points attempt to diminish or omit the pros and emphasize the cons of things.
E.g. ports. You don't notice that the Framework ports also work with everything else that a dongle does. You also don't notice that having modular ports provides extraordinary durability. Ports are often a thing that gets destroyed on laptops. Repairing often means a main board replacement. With a Framework, it's $20 port card and 10 seconds of work.
You compare their parts situation to Apple's by omitting the important fact that Framework's parts, especially the wear and tear ones like coolers, keyboards and batteries are dirt cheap and easily available for purchase. I don't know about you but I've replaced many ThinkPad batteries over the years and finding genuine ones is often a pain and they're invariably very expensive. 2-3x more expensive than what a Framework battery is.
Personally, I've already seen the benefits of the Framework model. I have a Framework 13 which I nastily dropped and bent as a result. One bottom cover order and replacement later it's as good as new.
I think the Framework model is absolutely positive for the industry, so long as it keeps working. If they go out of business in a year, or get sold to some profit maximizing group that disrupts the model, then yeah, at that point it may become a negative. In my opinion this is the risk for this company and this product model.